Coding Blocks avatar

Dexa/Coding Blocks

Learn more
Published Jun 8, 2020

Google’s Engineering Practices – How to Navigate a Code Review

Joe Zack and Alan Underwood delve into Google's engineering practices, dissecting the nuances of navigating code reviews with effective strategies for managing change lists and feedback. They also tackle tech challenges in Kubernetes port forwarding and Google's Dataproc, emphasizing the importance of accurate documentation and efficient tooling.
Episode Highlights
Coding Blocks logo

Topics covered

Popular Clips

Episode Highlights

  • Navigating CLs

    Navigating change lists effectively is crucial in code reviews, as emphasized by and . They highlight the importance of quickly addressing whether a change makes sense and providing constructive feedback. Alan stresses the need for courtesy in responses, suggesting that reviewers should explain why a change is necessary and offer guidance on improvements 1. Joe adds that reviewing the most significant changes first can prevent wasted effort on subsequent tasks 2. This approach ensures developers receive timely feedback, allowing them to meet deadlines efficiently 3.

       

    Review Challenges

    Code review challenges often arise from unclear boundaries and large code changes. Joe and Alan discuss the difficulties of managing extensive pull requests and the importance of having clear standards to guide reviews 4. Joe notes that separating changes can be complex, especially when multiple files are interdependent 5. Alan suggests that when a change list is too large to comprehend, developers should guide reviewers through the changes or split them into smaller, manageable parts 6.

       

    Review Comments

    Crafting effective code review comments is an art that balances constructive criticism with solutions. Joe emphasizes the importance of providing clear, actionable feedback and maintaining a professional tone 7. Alan suggests using README files to set clear guidelines for code contributions, which can streamline the review process and reduce misunderstandings 8. This proactive approach not only saves time but also fosters a more efficient and collaborative coding environment.

Related Episodes