Episode 400: Michaela Greiler on Code Reviews

Training

Training and education play a crucial role in enhancing code review skills, yet they are often overlooked in both academic and professional settings. Felienne Hermans and Michaela Greiler discuss how code reviews are rarely taught in universities or companies, leading to engineers learning through trial and error 1. Michaela suggests that companies like Microsoft and Google invest in understanding and improving code review practices, emphasizing the need for structured training programs 1.

Engineers are asked to do code reviews without any training, without any introduction to what is actually expected of them.

--- Michaela Greiler

Pairing up for code reviews and organizing lunch meetings to discuss best practices are recommended strategies to foster a learning environment 2.

   

Goal Setting

Setting clear goals is essential for effective code review processes, as it helps balance speed and rigor. Felienne Hermans highlights that different companies prioritize different aspects, such as speed at Google or rigor at other firms, affecting the review process 3. Michaela emphasizes the importance of understanding when to conduct thorough reviews versus quick ones, depending on the project's needs 4.

You can have a three-hour code review where you really catch everything, or you can have a five-minute code review where maybe some useful things are said, but definitely not everything.

--- Felienne Hermans

This balance ensures that code reviews are both efficient and comprehensive, aligning with the organization's objectives.